Trump said Monday that he has cut a deal with chipmaker Nvidia, allowing it to sell certain artificial intelligence chips to China in exchange for a cut of the revenue, which would go to the U.S. government. Trump said he also negotiated a similar deal with chipmaker Advanced Micro Devices (AMD).

Nvidia struck a surprising deal after convincing the president that H20 chips aren’t a national security risk. But whether the reversal is good or bad depends on who you ask.

Nvidia hopes to deliver samples to Chinese clients for testing as early as next month, although US regulatory approval is not guaranteed.